Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't Panic #651

Merged
merged 5 commits into from
Oct 9, 2020
Merged

Don't Panic #651

merged 5 commits into from
Oct 9, 2020

Conversation

CleanCut
Copy link
Member

@CleanCut CleanCut commented Oct 9, 2020

Same as #649 for despawn_recursive too.

@CleanCut
Copy link
Member Author

CleanCut commented Oct 9, 2020

Weird, I wonder why the first two commits show up again even though they've already been merged into master in #649? Maybe it's because I re-used the same branch?

@CleanCut
Copy link
Member Author

CleanCut commented Oct 9, 2020

Hmm. After resolving the changelog merge conflict the diff part from the first two commits disappeared. At least that's sane.

@cart
Copy link
Member

cart commented Oct 9, 2020

yeah i think its because the squash resulted in a new commit, which means you're adding "new" commits to the history.

@cart
Copy link
Member

cart commented Oct 9, 2020

In this case its harmless because I'm going to squash this pr too :)

@CleanCut
Copy link
Member Author

CleanCut commented Oct 9, 2020

Ah, squash-n-merges, that makes sense.

@cart cart merged commit 333fd3f into bevyengine:master Oct 9, 2020
@karroffel karroffel added C-Code-Quality A section of code that is hard to understand or change P-Crash A sudden unexpected crash A-ECS Entities, components, systems, and events labels Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change P-Crash A sudden unexpected crash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants